Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Solitaire game #4613

Closed
wants to merge 15 commits into from
Closed

Adding Solitaire game #4613

wants to merge 15 commits into from

Conversation

nikki-05
Copy link
Contributor

@nikki-05 nikki-05 commented Jun 18, 2024 •
edited
Loading

Created a new game page for Solitaire with the simplest design. ->Implemented game logic for Solitaire, including shuffle, deal, and move functionalities. ->made the game easy and simple
->Tested the Solitaire game for various browsers

PR Description 📜

Integrated Solitaire game into the existing game website.
Created a new game page for Solitaire with a simple design.
Implemented game logic for Solitaire, including shuffle, deal, and move functionalities.
Added card movements and interactions.
Instructions and rules for playing Solitaire are included on the game page.
Tested the Solitaire game for various browsers and screen sizes to ensure compatibility and responsiveness.
Fixed minor bugs related to card placement and game reset functionality.
will be fixing more issues related to the game
-Added the screenshot of the game image in the assets folder
-Made necessary changes to the CSS styling and enhancements
-Added link to the game in the main README.md
Fixes #4564

Mark the task you have completed ✅

  • [ x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [x ] I have performed a self-review of my own code or work.
  • [ x] I have commented my code, particularly in hard-to-understand areas..
  • [x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [x ] I have added entries for my game in main README.md
  • [x ] I have added README.md in my folder
  • [ x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸


Thank you soo much for contributing to our repository 💗

@nikki-05
Adding Solitaire game
2df47e6 
Created a new game page for Solitaire with responsive design.
->Implemented game logic for Solitaire, including shuffle, deal, and move functionalities.
->made the game easy and simple
->Tested the Solitaire game for various browsers
@kunjgit
Copy link
Owner

kunjgit commented Jun 18, 2024

Thank you @nikki-05 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@nikki-05
Copy link
Contributor Author

Thank you @nikki-05 ,for creating the PR and contributing to our GameZone 💗 Review team will review the PR and will reach out to you soon! 😇 Make sure that you have marked all the tasks that you are done with ✅. Thank you for your patience! 😀

hello sir, how do I tick mark ?

@nikki-05
Copy link
Contributor Author

hii @kunjgit may I know any update regarding the PR

ishita-43
ishita-43 requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the following changes
add your game image in asset folder of the gamezone follow naming convention while naming the image add your game entry to the main readme.md file of the gammezone follow format (refer other entries)
also in your pr description mark anychanges that applied to your pr example part of program

nikki-05 added 5 commits July 2, 2024 11:08
@nikki-05
Merge branch 'kunjgit:main' into main
011810f
@nikki-05
Update styles.css
7bd6df9 
improvements made to the CSS for better visual appearance, consistent card sizing, and improved drag-and-drop functionality.
@nikki-05
Update index.html
55e1f07
@nikki-05
Adding game image
9802100
@nikki-05
Single_Player_Solitaire
e348ca5
@nikki-05 nikki-05 requested a review from ishita-43 July 2, 2024 14:36
ishita-43
ishita-43 requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add your game entry into the main readme.md file of the repo refer other entries for the format

assets/images/Screenshot 2024-07-02 185338.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename as per naming convention for images should be same as game folder name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hii can you check please if it is done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its still not done you need to update readme.md file of the GameZone repo

@nikki-05 nikki-05 closed this Jul 7, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 7, 2024

Thank you @nikki-05 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Solitaire
3 participants
@nikki-05 @kunjgit @ishita-43